-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Activator SA #14133
Separate Activator SA #14133
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #14133 +/- ##
=======================================
Coverage 86.23% 86.24%
=======================================
Files 199 199
Lines 14795 14798 +3
=======================================
+ Hits 12759 12762 +3
Misses 1734 1734
Partials 302 302 ☔ View full report in Codecov by Sentry. |
/retest |
Co-authored-by: Kenjiro Nakayama <[email protected]>
/lgtm |
config/core/200-roles/activator.yaml
Outdated
@@ -0,0 +1,47 @@ | |||
# Copyright 2019 The Knative Authors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/2019/2023
@davidhadas gentle ping. @dprotaso if you have no objection I can merge. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidhadas, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
* Activator SA * Activator SA * Update config/core/200-roles/activator.yaml Co-authored-by: Kenjiro Nakayama <[email protected]> * s/2019/2023 --------- Co-authored-by: Kenjiro Nakayama <[email protected]>
Reduce privileges to Activator
See #13857