Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change storage version of DomainMapping to v1beta1 #14058

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jun 2, 2023

Fixes #14059

Proposed Changes

  • This deprecates DomainMapping v1alpha1 and changes the storage version to v1beta1

Release Note

DomainMapping/v1alpha1 is deprecated - use v1beta1 APIs

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 2, 2023
@knative-prow
Copy link

knative-prow bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2023
@dprotaso dprotaso changed the title change storage version of domain mapping Change storage version of domain mapping to v1beta1 Jun 2, 2023
@dprotaso dprotaso changed the title Change storage version of domain mapping to v1beta1 Change storage version of DomainMapping to v1beta1 Jun 2, 2023
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (d07bf78) 86.21% compared to head (6f35e55) 86.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14058      +/-   ##
==========================================
- Coverage   86.21%   86.19%   -0.03%     
==========================================
  Files         199      199              
  Lines       14767    14767              
==========================================
- Hits        12731    12728       -3     
- Misses       1734     1736       +2     
- Partials      302      303       +1     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dprotaso dprotaso changed the title Change storage version of DomainMapping to v1beta1 [WIP] Change storage version of DomainMapping to v1beta1 Jun 2, 2023
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2023
@dprotaso dprotaso changed the title [WIP] Change storage version of DomainMapping to v1beta1 Change storage version of DomainMapping to v1beta1 Jun 6, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 6, 2023
@nak3
Copy link
Contributor

nak3 commented Jun 7, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2023
@knative-prow knative-prow bot merged commit 7d0f963 into knative:main Jun 7, 2023
50 checks passed
@dprotaso dprotaso deleted the domain-change-storage-version branch September 6, 2023 20:57
skonto pushed a commit to skonto/serving that referenced this pull request Oct 5, 2023
* change storage version of domain mapping

* add domainmapping resource to post install job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate DomainMapping v1alpha1
2 participants