Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change minimum TLS version to 1.3 - tag to digest resolution #13886

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Change minimum TLS version to 1.3 - tag to digest resolution #13886

merged 1 commit into from
Apr 14, 2023

Conversation

izabelacg
Copy link
Member

@izabelacg izabelacg commented Apr 14, 2023

Proposed Changes

  • Change minimum TLS version (from 1.2 to 1.3) for tag to digest resolution

TLS 1.3 comes with numerous enhancements, such as a quicker TLS handshake and more secure cipher suites.

Release Note

* Controller uses TLS 1.3 as the minimum version when communicating with image registries for tag to digest resolution

@knative-prow knative-prow bot added area/API API objects and controllers size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/autoscale area/networking labels Apr 14, 2023
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 66.66% and no project coverage change.

Comparison is base (ef58d9b) 86.23% compared to head (e8e7187) 86.23%.

❗ Current head e8e7187 differs from pull request most recent head b35e117. Consider uploading reports for the commit b35e117 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13886   +/-   ##
=======================================
  Coverage   86.23%   86.23%           
=======================================
  Files         199      199           
  Lines       14706    14706           
=======================================
  Hits        12682    12682           
- Misses       1724     1725    +1     
+ Partials      300      299    -1     
Impacted Files Coverage Δ
cmd/activator/main.go 0.00% <0.00%> (ø)
pkg/activator/certificate/cache.go 41.81% <100.00%> (ø)
pkg/reconciler/revision/resolve.go 77.50% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2023
@knative-prow knative-prow bot merged commit 171cecd into knative:main Apr 14, 2023
@dprotaso dprotaso changed the title Change minimum TLS version to 1.3 Change minimum TLS version to 1.3 - tag to digest resolution Apr 14, 2023
kahirokunn added a commit to kahirokunn/knative-serving that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants