Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable emptyDir volumes for Knative Services #13405

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

dprotaso
Copy link
Member

Part of #11664

Proposed Changes

This switches the feature flag to enabled allowing users to
add emptyDir volumes to their containers.

This can be useful as a scratch space and for multiple
containers

Release Note

emptyDir volumes feature flag is now enabled by default

This switches the feature flag to enabled allowing users to
add emptyDir volumes to their containers.

This can be useful as a scratch space and for multiple
containers
@knative-prow knative-prow bot added area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2022
@dprotaso
Copy link
Member Author

/assign @nader-ziada @psschwei

/cc @evankanderson

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 86.47% // Head: 86.49% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (cf9c93f) compared to base (6264c1b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13405      +/-   ##
==========================================
+ Coverage   86.47%   86.49%   +0.02%     
==========================================
  Files         196      196              
  Lines       14551    14551              
==========================================
+ Hits        12583    12586       +3     
+ Misses       1669     1667       -2     
+ Partials      299      298       -1     
Impacted Files Coverage Δ
pkg/apis/config/features.go 95.38% <100.00%> (ø)
pkg/reconciler/configuration/configuration.go 82.93% <0.00%> (-1.43%) ⬇️
pkg/apis/serving/k8s_validation.go 94.21% <0.00%> (+0.45%) ⬆️
pkg/autoscaler/statforwarder/leases.go 73.95% <0.00%> (+1.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@psschwei
Copy link
Contributor

/test upgrade-tests

Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
@knative-prow
Copy link

knative-prow bot commented Oct 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 6e597fa into knative:main Oct 17, 2022
@dprotaso dprotaso deleted the empty-dir-enabled branch October 17, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants