Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kind 1.22 testing, since min-version will be 1.23 in the next release #13357

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Remove kind 1.22 testing, since min-version will be 1.23 in the next release #13357

merged 2 commits into from
Oct 5, 2022

Conversation

nader-ziada
Copy link
Member

Fixes #

Proposed Changes

Release Note

Bump min-version to k8s 1.23, so removing kind 1.22 testing

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 5, 2022
psschwei
psschwei reviewed Oct 5, 2022
View reviewed changes
.github/workflows/kind-e2e.yaml Outdated
- k8s-version: v1.22.9
kind-version: v0.14.0
kind-image-sha: sha256:8135260b959dfe320206eb36b3aeda9cffcb262f4b44cda6b33f7bb73f453105

- k8s-version: v1.23.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also bump the v1.23 and v1.24 versions to the latest patch releases?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

I think we will have to bump the kind version for 1.25.x when we add it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to update L90-91 to the new versions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry fixed

@codecov
Copy link

codecov bot commented Oct 5, 2022 •
edited
Loading

Codecov Report

Base: 86.47% // Head: 86.45% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (885220a) compared to base (8a11681).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13357      +/-   ##
==========================================
- Coverage   86.47%   86.45%   -0.03%     
==========================================
  Files         196      196              
  Lines       14548    14549       +1     
==========================================
- Hits        12581    12578       -3     
- Misses       1668     1671       +3     
- Partials      299      300       +1
Impacted Files Coverage Δ
pkg/reconciler/configuration/configuration.go 82.93% <0.00%> (-1.43%) ⬇️
cmd/activator/main.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 5, 2022
@psschwei
Copy link
Contributor

psschwei commented Oct 5, 2022

looks like GH actions are having issues right now...

@psschwei
Copy link
Contributor

psschwei commented Oct 5, 2022

and right as I say that, they kick off 😆

@nader-ziada
Copy link
Member Author

/retest

@nader-ziada nader-ziada changed the title Remove kind 1.22 testing, since we will min-version 1.23 in the next release Remove kind 1.22 testing, since min-version will be 1.23 in the next release Oct 5, 2022
@nader-ziada
Copy link
Member Author

@psschwei ready

psschwei
psschwei reviewed Oct 5, 2022
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2022
@knative-prow
Copy link

knative-prow bot commented Oct 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nader-ziada, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2022
@knative-prow knative-prow bot merged commit c3f3eae into knative:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei left review comments

Assignees

@psschwei psschwei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nader-ziada @psschwei