-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove kind 1.22 testing, since min-version will be 1.23 in the next release #13357
Conversation
.github/workflows/kind-e2e.yaml
Outdated
- k8s-version: v1.22.9 | ||
kind-version: v0.14.0 | ||
kind-image-sha: sha256:8135260b959dfe320206eb36b3aeda9cffcb262f4b44cda6b33f7bb73f453105 | ||
|
||
- k8s-version: v1.23.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also bump the v1.23 and v1.24 versions to the latest patch releases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
I think we will have to bump the kind version for 1.25.x when we add it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to update L90-91 to the new versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry fixed
Codecov ReportBase: 86.47% // Head: 86.45% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #13357 +/- ##
==========================================
- Coverage 86.47% 86.45% -0.03%
==========================================
Files 196 196
Lines 14548 14549 +1
==========================================
- Hits 12581 12578 -3
- Misses 1668 1671 +3
- Partials 299 300 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
looks like GH actions are having issues right now... |
and right as I say that, they kick off 😆 |
/retest |
eaf9fa8
to
885220a
Compare
@psschwei ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nader-ziada, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #
Proposed Changes
Release Note