Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade k8s HorizontalPodAutoscaler to v2 #13337

Merged
merged 1 commit into from
Oct 7, 2022
Merged

upgrade k8s HorizontalPodAutoscaler to v2 #13337

merged 1 commit into from
Oct 7, 2022

Conversation

nader-ziada
Copy link
Member

Fixes #12806

Proposed Changes

  • upgrade k8s autoscaling to v2

Release Note

upgrade HorizontalPodAutoscaler to autoscaling/v2 API version

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/API API objects and controllers area/autoscale area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022 •
edited
Loading

Codecov Report

Base: 86.49% // Head: 86.40% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (42d1377) compared to base (6463604).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13337      +/-   ##
==========================================
- Coverage   86.49%   86.40%   -0.09%     
==========================================
  Files         196      196              
  Lines       14549    14549              
==========================================
- Hits        12584    12571      -13     
- Misses       1667     1676       +9     
- Partials      298      302       +4
Impacted Files Coverage Δ
pkg/reconciler/autoscaling/hpa/controller.go 100.00% <ø> (ø)
pkg/reconciler/autoscaling/hpa/hpa.go 91.66% <100.00%> (ø)
pkg/reconciler/autoscaling/hpa/resources/hpa.go 100.00% <100.00%> (ø)
pkg/autoscaler/statforwarder/processor.go 88.00% <0.00%> (-6.00%) ⬇️
pkg/autoscaler/statforwarder/forwarder.go 90.66% <0.00%> (-5.34%) ⬇️
pkg/autoscaler/statforwarder/leases.go 72.39% <0.00%> (-1.57%) ⬇️
pkg/reconciler/configuration/configuration.go 82.93% <0.00%> (-1.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nader-ziada
Copy link
Member Author

the autoscaling/v2 API version, available since v1.23. so the 1.22 tests are failing, but there is already a PR in pkg to set the min version to 1.23 knative/pkg#2595

will hold for that

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2022
@nader-ziada
Copy link
Member Author

/retest

@psschwei psschwei closed this Oct 6, 2022
@psschwei psschwei reopened this Oct 6, 2022
@nader-ziada nader-ziada changed the title [WIP] upgrade k8s HorizontalPodAutoscaler to v2 upgrade k8s HorizontalPodAutoscaler to v2 Oct 6, 2022
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2022
@nader-ziada
Copy link
Member Author

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2022
@skonto
Copy link
Contributor

skonto commented Oct 7, 2022 •
edited
Loading

@nader-ziada if this is ready we can stamp it, LGTM.

@nader-ziada
Copy link
Member Author

@nader-ziada if this is ready we can stamp it, LGTM.

yeah I think its ready

psschwei
psschwei reviewed Oct 7, 2022
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2022
@knative-prow
Copy link

knative-prow bot commented Oct 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nader-ziada, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2022
@nader-ziada
Copy link
Member Author

/retest

@nader-ziada
Copy link
Member Author

/easycla

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2022
@nader-ziada
Copy link
Member Author

@psschwei will need another lgtm here as I had to rebase to get the PR unstuck

psschwei
psschwei reviewed Oct 7, 2022
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2022
nak3 pushed a commit to nak3/serving that referenced this pull request Nov 30, 2022
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
5f34a29 
This reverts commit 974d19d.
nak3 pushed a commit to nak3/serving that referenced this pull request Nov 30, 2022
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
8b4a7f2 
This reverts commit 974d19d.
nak3 pushed a commit to nak3/serving that referenced this pull request Dec 1, 2022
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
ce0cd3e 
This reverts commit 974d19d.
nak3 pushed a commit to nak3/serving that referenced this pull request Dec 2, 2022
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
89b9fd9 
This reverts commit 974d19d.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Dec 12, 2022
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
617da66 
This reverts commit 974d19d.
nak3 pushed a commit to nak3/serving that referenced this pull request Dec 15, 2022
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
cc600d0 
This reverts commit 974d19d.
nak3 pushed a commit to nak3/serving that referenced this pull request Dec 19, 2022
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
42c8abe 
This reverts commit 974d19d.
nak3 pushed a commit to nak3/serving that referenced this pull request Dec 20, 2022
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
d55b5c4 
This reverts commit 974d19d.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Dec 24, 2022
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
5c63660 
This reverts commit 974d19d.
nak3 pushed a commit to nak3/serving that referenced this pull request Dec 26, 2022
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
e8ef4fb 
This reverts commit 974d19d.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Jan 7, 2023
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
e76fde4 
This reverts commit 974d19d.
ReToCode pushed a commit to ReToCode/serving that referenced this pull request Jan 11, 2023
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
1dbfc3f 
This reverts commit 974d19d.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Jan 14, 2023
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
7f2e4f5 
This reverts commit 974d19d.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Jan 17, 2023
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
852faae 
This reverts commit 974d19d.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Jan 19, 2023
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
720e12d 
This reverts commit 974d19d.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Jan 20, 2023
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
7af6277 
This reverts commit 974d19d.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Jan 21, 2023
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
80beb0e 
This reverts commit 974d19d.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Jan 23, 2023
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
5658ee7 
This reverts commit 974d19d.
nak3 pushed a commit to nak3/serving that referenced this pull request Jan 26, 2023
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
2c59a3b 
This reverts commit 974d19d.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Jan 27, 2023
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
28e0e65 
This reverts commit 974d19d.
ReToCode pushed a commit to ReToCode/serving that referenced this pull request Jan 30, 2023
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
115fc24 
This reverts commit 974d19d.
ReToCode pushed a commit to ReToCode/serving that referenced this pull request Jan 31, 2023
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
95a0e0c 
This reverts commit 974d19d.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Feb 3, 2023
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
a19cf1e 
This reverts commit 974d19d.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Feb 4, 2023
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
4aecd2f 
This reverts commit 974d19d.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Feb 11, 2023
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
02a5c66 
This reverts commit 974d19d.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Feb 18, 2023
@serverless-qe
Revert "upgrade k8s autoscaling to v2 (knative#13337)"
e98e330 
This reverts commit 974d19d.
ReToCode added a commit to ReToCode/serving that referenced this pull request Feb 21, 2023
@ReToCode
Revert "Revert "upgrade k8s autoscaling to v2 (knative#13337)" (knati…
aa4bebd 
…ve#8)"

This reverts commit 4abc477.
openshift-merge-robot pushed a commit to openshift-knative/serving that referenced this pull request Mar 2, 2023
@ReToCode
[RELEASE-1.8] Re-introducing knative#13337 (#179)
67c19d1 
* Revert "Revert "upgrade k8s autoscaling to v2 (knative#13337)" (#8)"

This reverts commit 4abc477.

* Re-introducing 42d1377

* Run `./openshift/release/generate-release.sh`
nak3 added a commit to nak3/serving that referenced this pull request Mar 3, 2023
@nak3
Revert "upgrade k8s autoscaling to v2 (knative#13337)" (#8)
d1fa989 
This reverts commit 974d19d.
nak3 pushed a commit to nak3/serving that referenced this pull request Mar 3, 2023
@ReToCode @nak3
[RELEASE-1.8] Re-introducing knative#13337 (knative#179)
65ccb07 
* Revert "Revert "upgrade k8s autoscaling to v2 (knative#13337)" (#8)"

This reverts commit 4abc477.

* Re-introducing 42d1377

* Run `./openshift/release/generate-release.sh`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei left review comments

Assignees

@psschwei psschwei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HorizonalPodAutoscaler deprecation
3 participants
@nader-ziada @skonto @psschwei