Add timeout handler to activator to respect the revision timeouts #13261
Conversation
knative-prow
bot
added
do-not-merge/work-in-progress
Codecov Report
@@ Coverage Diff @@
## main #13261 +/- ##
==========================================
- Coverage 86.58% 86.49% -0.09%
==========================================
Files 196 196
Lines 14511 14526 +15
==========================================
Hits 12564 12564
- Misses 1648 1663 +15
Partials 299 299
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nader-ziada
force-pushed
the
activator-timeout-handler
branch
from
2215530
to
4e44aa9
Compare
nader-ziada
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
|
@psschwei can you take a look when you get a chance? |
pkg/http/handler/timeout.go
Outdated
| timeout time.Duration | ||
| responseStartTimeout time.Duration | ||
| idleTimeout time.Duration |
There was a problem hiding this comment.
Do we still need these in the struct, or could we get by with local variables in the ServeHTTP method?
There was a problem hiding this comment.
Or alternatively, could we do the timeoutFunc logic in the activator main body (similar to how it's done for QP) and leave the struct unchanged?
There was a problem hiding this comment.
I believe the activator doesn't have the same env variables for the Revision, so its need to get it from the request and that's why I did the func , but removing the struct makes sense
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nader-ziada, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
…ative#13261) * add timeout handler to activator * remove unnecessary fields from timeout struct
…ative#13261) (#97) * add timeout handler to activator * remove unnecessary fields from timeout struct Co-authored-by: Nader Ziada <[email protected]>
Fixes #12728
Proposed Changes
Release Note