-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revision request start timeout should default to revision timeout second #13255
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @nader-ziada |
/lgtm |
Codecov Report
@@ Coverage Diff @@
## main #13255 +/- ##
==========================================
+ Coverage 86.58% 86.61% +0.02%
==========================================
Files 196 196
Lines 14505 14511 +6
==========================================
+ Hits 12559 12568 +9
+ Misses 1648 1646 -2
+ Partials 298 297 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/cherry-pick release-1.7 |
@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override istio-latest-no-mesh_serving_main |
@dprotaso: Overrode contexts on behalf of dprotaso: istio-latest-no-mesh_serving_main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/override test (v1.24.0, contour, e2e) |
@dprotaso: Overrode contexts on behalf of dprotaso: test (v1.24.0, contour, e2e) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dprotaso: new pull request created: #13257 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Proposed Changes
revision-response-start-timeout-seconds
now defaults torevision-timeout-seconds
. This should unblock upgrades who setrevision-timeout-seconds
lower than the default value of 300Release Note