Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revision request start timeout should default to revision timeout second #13255

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Aug 24, 2022

Proposed Changes

  • ConfigMap config-defaults property revision-response-start-timeout-seconds now defaults to revision-timeout-seconds. This should unblock upgrades who set revision-timeout-seconds lower than the default value of 300

Release Note

ConfigMap config-defaults property `revision-response-start-timeout-seconds` now defaults to `revision-timeout-seconds`. This should unblock upgrades who set `revision-timeout-seconds` lower than the default value of 300

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 24, 2022
@knative-prow
Copy link

knative-prow bot commented Aug 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers labels Aug 24, 2022
@dprotaso
Copy link
Member Author

/assign @nader-ziada

@nader-ziada
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #13255 (78e76a0) into main (d79b8bb) will increase coverage by 0.02%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main   #13255      +/-   ##
==========================================
+ Coverage   86.58%   86.61%   +0.02%     
==========================================
  Files         196      196              
  Lines       14505    14511       +6     
==========================================
+ Hits        12559    12568       +9     
+ Misses       1648     1646       -2     
+ Partials      298      297       -1     
Impacted Files Coverage Δ
pkg/apis/config/defaults.go 85.24% <57.14%> (+0.76%) ⬆️
pkg/reconciler/revision/reconcile_resources.go 66.88% <0.00%> (-1.99%) ⬇️
pkg/reconciler/configuration/configuration.go 85.20% <0.00%> (+1.53%) ⬆️
pkg/autoscaler/statforwarder/leases.go 73.95% <0.00%> (+1.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dprotaso
Copy link
Member Author

/cherry-pick release-1.7

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member Author

/override istio-latest-no-mesh_serving_main

@knative-prow
Copy link

knative-prow bot commented Aug 24, 2022

@dprotaso: Overrode contexts on behalf of dprotaso: istio-latest-no-mesh_serving_main

In response to this:

/override istio-latest-no-mesh_serving_main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member Author

/retest

@dprotaso
Copy link
Member Author

/override test (v1.24.0, contour, e2e)

@knative-prow
Copy link

knative-prow bot commented Aug 24, 2022

@dprotaso: Overrode contexts on behalf of dprotaso: test (v1.24.0, contour, e2e)

In response to this:

/override test (v1.24.0, contour, e2e)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit b36de60 into knative:main Aug 24, 2022
@dprotaso dprotaso deleted the serving-defaulting branch August 24, 2022 17:03
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #13257

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants