Fix LatestReadyRevision semantics - it only advances forward #13239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The search for latest ready revision (LLR) looked at each revision's configurationGeneration label to search for a new candidate. Only Revisions with a configurationGeneration in a certain range were considered. Prior this inclusive range was [LLR.generation, config.generation]. The lower bound was incorrect and it should actually be LLR.configGeneration. Otherwise LLR generation is fairly low the the set of revision to consider would be quite large for really old Configurations.
knative-prow
bot
added
area/API
Codecov ReportBase: 86.56% // Head: 86.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #13239 +/- ##
==========================================
- Coverage 86.56% 86.48% -0.09%
==========================================
Files 196 196
Lines 14505 14544 +39
==========================================
+ Hits 12556 12578 +22
- Misses 1650 1666 +16
- Partials 299 300 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Looks like BYO revision name has a broken edge case |
|
/hold for after 1.7 |
knative-prow
bot
added
the
do-not-merge/hold
This is required to support git revert in combination with a Knative Service that has latestRevision: true in their Route traffic block
knative-prow
bot
added
the
area/test-and-release
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
size/L
Prior the conditional was not correct and the generation was not part of the selector. Also made sure the unit test failed prior to applying the fix.
|
/assign @psschwei @nader-ziada |
|
/hold cancel |
knative-prow
bot
removed
the
do-not-merge/hold
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12538 #12078
Proposed Changes
From commit message
Release Note