stop the queue-proxy drain if we don't receive a TERM signal #13229
Conversation
- this implies the user-container is being restarted but not the entire pod
knative-prow
bot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
approved
|
/assign @nader-ziada |
Codecov Report
@@ Coverage Diff @@
## main #13229 +/- ##
==========================================
- Coverage 86.62% 86.53% -0.09%
==========================================
Files 196 196
Lines 14495 14505 +10
==========================================
- Hits 12556 12552 -4
- Misses 1640 1653 +13
- Partials 299 300 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| go func() { | ||
| select { | ||
| case <-ctx.Done(): | ||
| case <-time.After(time.Second): |
There was a problem hiding this comment.
so you check for this every 1 second the whole time the server is running?
There was a problem hiding this comment.
No - there's no for loop and it's in the /wait-for-drain handler.
|
/lgtm |
/retest |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
/retest |
Signed-off-by: Brad Beam <[email protected]>
This takes the spirit of knative#13229 and backports it to our version. Upstream change was made after the refactoring/moving of this code in To avoid bumping the knative/pkg dependency, an updated Drainer was copied over. Relevent commits: Queue Proxy: knative@ea5c535 Drainer: https://github.com/knative/pkg/blob/97c7258e3a98b81459936bc7a29dc6a9540fa357/network/handlers/drain.go Signed-off-by: Brad Beam <[email protected]>
fix: Backport knative#13229
Fixes #12571
Proposed Changes
Release Note