Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping go.mod to v1.18 #13169

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Bumping go.mod to v1.18 #13169

merged 1 commit into from
Jul 29, 2022

Conversation

psschwei
Copy link
Contributor

@psschwei psschwei commented Jul 28, 2022

Signed-off-by: Paul S. Schweigert [email protected]

Looks like I missed this in the last round of updates...

Release Note

Knative Serving requires go v1.18

/assign @dprotaso

Signed-off-by: Paul S. Schweigert <[email protected]>
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2022
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #13169 (2851fd6) into main (0b694b0) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13169      +/-   ##
==========================================
+ Coverage   86.69%   86.71%   +0.02%     
==========================================
  Files         196      196              
  Lines       14450    14450              
==========================================
+ Hits        12527    12530       +3     
+ Misses       1626     1624       -2     
+ Partials      297      296       -1     
Impacted Files Coverage Δ
pkg/reconciler/revision/background.go 92.72% <0.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b694b0...2851fd6. Read the comment docs.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2022
@knative-prow
Copy link

knative-prow bot commented Jul 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit f846b2c into knative:main Jul 29, 2022
@psschwei psschwei deleted the bump-go branch August 10, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants