Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating name of activation-scale #13161

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Conversation

psschwei
Copy link
Contributor

@psschwei psschwei commented Jul 27, 2022

Signed-off-by: Paul S. Schweigert [email protected]

Release Note

Adds a `autoscaling.knative.dev/activation-scale` annotation that allows the user to set a minimum number of replicas when not scaled to zero. Note that the initial target scale for a revision is still handled by `initial-scale`; `activation-scale` will only apply on subsequent scales from zero. 

Signed-off-by: Paul S. Schweigert <[email protected]>
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/API API objects and controllers area/autoscale labels Jul 27, 2022
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2022
@knative-prow
Copy link

knative-prow bot commented Jul 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2022
@dprotaso
Copy link
Member

Previous PR: #13136

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #13161 (d9250fa) into main (addd55a) will increase coverage by 0.02%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##             main   #13161      +/-   ##
==========================================
+ Coverage   86.69%   86.71%   +0.02%     
==========================================
  Files         196      196              
  Lines       14450    14450              
==========================================
+ Hits        12527    12530       +3     
+ Misses       1626     1624       -2     
+ Partials      297      296       -1     
Impacted Files Coverage Δ
pkg/autoscaler/scaling/multiscaler.go 88.59% <ø> (ø)
pkg/autoscaler/scaling/autoscaler.go 96.84% <66.66%> (ø)
pkg/apis/autoscaling/annotation_validation.go 95.23% <75.00%> (ø)
pkg/apis/autoscaling/v1alpha1/pa_lifecycle.go 100.00% <100.00%> (ø)
...kg/reconciler/autoscaling/kpa/resources/decider.go 100.00% <100.00%> (ø)
pkg/autoscaler/statforwarder/leases.go 73.95% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update addd55a...d9250fa. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants