Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove git files from kodata #13130

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Conversation

dprotaso
Copy link
Member

see: knative/pkg#2548

Proposed Changes

  • drop kodata/HEAD kodata/refs from container images
  • build info (vcs.revision) is now embedded in the go binary with go1.18

Release Note

Build commit SHA is no longer under kodata in our containers it is now embedded in the binary since we build with go1.18. Use `go version -m [binary]` to get the same information

build info (vcs.revision) is now embedded in the go binary with go1.18

see: knative/pkg#2548
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 18, 2022
@dprotaso dprotaso changed the title Don't included git info in our containers Remove git files from kodata Jul 18, 2022
@knative-prow
Copy link

knative-prow bot commented Jul 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added area/API API objects and controllers area/autoscale area/networking approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Jul 18, 2022
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #13130 (b6267cd) into main (d366049) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13130      +/-   ##
==========================================
+ Coverage   86.78%   86.84%   +0.05%     
==========================================
  Files         196      196              
  Lines       14410    14410              
==========================================
+ Hits        12506    12514       +8     
+ Misses       1609     1603       -6     
+ Partials      295      293       -2     
Impacted Files Coverage Δ
pkg/activator/net/revision_backends.go 93.35% <0.00%> (+0.57%) ⬆️
pkg/reconciler/configuration/configuration.go 85.20% <0.00%> (+1.53%) ⬆️
pkg/reconciler/revision/background.go 92.72% <0.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d366049...b6267cd. Read the comment docs.

@dprotaso
Copy link
Member Author

/assign @nader-ziada

@nader-ziada
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2022
@knative-prow knative-prow bot merged commit 017b9d0 into knative:main Jul 18, 2022
@dprotaso dprotaso deleted the drop-vcs-info branch July 25, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants