Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow unknown fields in our webhooks since our CRD schemas are now specified #13111

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

dprotaso
Copy link
Member

Fixes #11980

Proposed Changes

Release Note

Our webhooks no longer reject unknown fields since they're pruned by the K8s API server

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/API API objects and controllers approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 11, 2022
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #13111 (b465851) into main (838305e) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13111      +/-   ##
==========================================
- Coverage   86.78%   86.75%   -0.04%     
==========================================
  Files         197      197              
  Lines       14485    14485              
==========================================
- Hits        12571    12566       -5     
- Misses       1619     1623       +4     
- Partials      295      296       +1     
Impacted Files Coverage Δ
pkg/reconciler/revision/reconcile_resources.go 66.88% <0.00%> (-1.99%) ⬇️
pkg/autoscaler/scaling/multiscaler.go 87.24% <0.00%> (-1.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 838305e...b465851. Read the comment docs.

@dprotaso
Copy link
Member Author

/assign @psschwei

Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold
for #13095

@knative-prow knative-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jul 11, 2022
@knative-prow
Copy link

knative-prow bot commented Jul 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@psschwei
Copy link
Contributor

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2022
@knative-prow knative-prow bot merged commit e2862ae into knative:main Jul 11, 2022
@dprotaso dprotaso deleted the allow-unknown branch July 11, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

See if it's possible to drop x-kubernetes-preserve-unknown-fields
2 participants