Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop EnableAlphaFeatures from TestHttpRedirect #13084

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Drop EnableAlphaFeatures from TestHttpRedirect #13084

merged 1 commit into from
Jul 5, 2022

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Jul 4, 2022

As per design doc attached knative/networking#301,

After 4 subsequent releases of Alpha stage, this feature will automatically enter Stable phase as the conformance test and E2E test will have been added in the previous phases.

So this patch drops EnableAlphaFeatures from TestHttpRedirect.

Release Note

HTTPRedirect feature is marked as stable.

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 4, 2022
@nak3
Copy link
Contributor Author

nak3 commented Jul 5, 2022

/cc @ZhiminXiang @dprotaso @psschwei

psschwei
psschwei approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per testgrid, this one has been passing for a while

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2022
@knative-prow
Copy link

knative-prow bot commented Jul 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 70c3309 into knative:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei approved these changes

@dprotaso dprotaso Awaiting requested review from dprotaso

@ZhiminXiang ZhiminXiang Awaiting requested review from ZhiminXiang

Assignees

@psschwei psschwei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nak3 @psschwei