-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds progressDeadline annotation on per revision basis #12751
Conversation
Signed-off-by: Paul S. Schweigert <[email protected]> This PR allows setting the progress-deadline on each revision by passing an annotation, autoscaling.knative.dev/progressDeadline. It aims to improve the experience where revisions don't fail until the progressDeadline is reached, which by default is 10 minutes. Not everyone necessarily wants to wait that long, but previously the only resource was for the cluster admin to lower the deadline universally (i.e. change the default). With this change, we allow users to "fail fast", if they so desire.
Codecov Report
@@ Coverage Diff @@
## main #12751 +/- ##
==========================================
+ Coverage 87.31% 87.49% +0.18%
==========================================
Files 196 196
Lines 9750 9782 +32
==========================================
+ Hits 8513 8559 +46
+ Misses 951 935 -16
- Partials 286 288 +2
Continue to review full report at Codecov.
|
/test pull-knative-serving-unit-tests |
Signed-off-by: Paul S. Schweigert <[email protected]>
/assign @nader-ziada |
nice PR, /lgtm |
sorry - clicked comment vs add review - I still have more to review but I need to step out right now so I'll revisit this later tonight |
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
/retest |
/test istio-latest-no-mesh-tls_serving_main |
I think we should consider changing the group name of the key to be
Long term we could expose this as field on the revision |
I went back and forth (and back again) on this when I was putting the PR together. I ended up using |
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
/lgtm |
Signed-off-by: Paul S. Schweigert <[email protected]>
/lgtm Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
weird flake uploading the image |
Signed-off-by: Paul S. Schweigert [email protected]
Fixes #12743
Proposed Changes
This PR allows setting the progress-deadline on each revision by passing
an annotation, serving.knative.dev/progress-deadline. It aims to
improve the experience where revisions don't fail until the
progressDeadline is reached, which by default is 10 minutes. Not
everyone necessarily wants to wait that long, but previously the only
resource was for the cluster admin to lower the deadline
universally (i.e. change the default). With this change, we allow users
to "fail fast", if they so desire.
Release Note
/assign @dprotaso