Adds detail to initialScale validation error msgs

[psschwei]

Signed-off-by: Paul S. Schweigert [email protected]

Proposed Changes

Originally, validateInitialScale returned an ErrInvalidValue for any
invalid value. This PR adds more specific error messages for the cases
when either a negative value is used or if initialScale=0 when not
allowed by the cluster.

Release Note

Provides more detailed error messages for invalid values of autoscaling.knative.dev/initial-scale

[dprotaso]

unit tests are failures are legit - error messages need updating

[psschwei]

That's what I get for only running the unit buckets in the same directory :)

[codecov]

Codecov Report

Merging #12704 (4be61b3) into main (d59e273) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main   #12704   +/-   ##
=======================================
  Coverage   87.30%   87.30%           
=======================================
  Files         196      196           
  Lines        9741     9745    +4     
=======================================
+ Hits         8504     8508    +4     
- Misses        951      952    +1     
+ Partials      286      285    -1     

Impacted Files	Coverage Δ
pkg/apis/autoscaling/annotation_validation.go	100.00% <100.00%> (ø)
pkg/autoscaler/statserver/server.go	77.66% <0.00%> (-1.95%)	⬇️
pkg/reconciler/configuration/configuration.go	86.15% <0.00%> (+1.53%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d59e273...4be61b3. Read the comment docs.

[dprotaso]

it happens and that's what presubmits are for :)

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nader-ziada]

/lgtm