Fixes validation bug for autoscaling/target #12698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul S. Schweigert <[email protected]> Fixed autoscaling.knative.dev/target validation logic so that an invalid value error is returned if an invalid value is provided. Previous logic did not distinguish between invalid values and a value less than the minimum in the error message.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #12698 +/- ##
==========================================
+ Coverage 87.25% 87.32% +0.06%
==========================================
Files 196 196
Lines 9739 9741 +2
==========================================
+ Hits 8498 8506 +8
+ Misses 955 950 -5
+ Partials 286 285 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul S. Schweigert [email protected]
Fixed autoscaling.knative.dev/target validation logic so that an
invalid value error is returned if an invalid value is provided.
Previous logic did not distinguish between invalid values and a
value less than the minimum in the error message.
Release Note