Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an activator panic when the throttle encounters a cache.DeleteFinalStateUnknown #12679

Merged
merged 1 commit into from
Feb 27, 2022

Conversation

dprotaso
Copy link
Member

Fixes #12676

Note: I couldn't figure out a way to reproduce this with the client-go fakes

Release Note

Fix an activator crash that could disrupt traffic (503)

@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 27, 2022
@dprotaso
Copy link
Member Author

/cherry-pick release-1.2

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added area/autoscale area/networking approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 27, 2022
@dprotaso
Copy link
Member Author

flaky - #12490

/retest

@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #12679 (8737b65) into main (d48569e) will increase coverage by 0.04%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12679      +/-   ##
==========================================
+ Coverage   87.27%   87.31%   +0.04%     
==========================================
  Files         196      196              
  Lines        9736     9739       +3     
==========================================
+ Hits         8497     8504       +7     
+ Misses        952      950       -2     
+ Partials      287      285       -2     
Impacted Files Coverage Δ
pkg/activator/net/throttler.go 87.95% <40.00%> (-0.90%) ⬇️
pkg/reconciler/revision/background.go 91.81% <0.00%> (+1.81%) ⬆️
pkg/autoscaler/statforwarder/processor.go 94.44% <0.00%> (+5.55%) ⬆️
pkg/autoscaler/statforwarder/forwarder.go 96.29% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d48569e...8737b65. Read the comment docs.

@dprotaso
Copy link
Member Author

/retest

@nader-ziada
Copy link
Member

/lgtm

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #12680

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso dprotaso deleted the activator-crash branch February 28, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale area/networking lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some 503s being caused by activator panic & container restart
3 participants