Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump ggcr which includes auth config lookup fixes for k8s #12655

Merged
merged 1 commit into from
Feb 23, 2022
Merged

bump ggcr which includes auth config lookup fixes for k8s #12655

merged 1 commit into from
Feb 23, 2022

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Feb 23, 2022 •
edited
Loading

Part of #12642

Includes the fixes:

Release Note

Fix tag to digest resolution when the registry credential is in a K8s secret

@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 23, 2022
@dprotaso dprotaso changed the title bump ggcr which includes fixes when looking up k8s auth bump ggcr which includes fixes when looking up k8s registry auth Feb 23, 2022
@dprotaso dprotaso changed the title bump ggcr which includes fixes when looking up k8s registry auth bump ggcr which includes auth config lookup fixes for k8s Feb 23, 2022
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #12655 (2adf74a) into main (7e1dd36) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 2adf74a differs from pull request most recent head ed6c6b9. Consider uploading reports for the commit ed6c6b9 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12655      +/-   ##
==========================================
- Coverage   87.50%   87.47%   -0.03%     
==========================================
  Files         195      195              
  Lines        9712     9712              
==========================================
- Hits         8498     8496       -2     
- Misses        929      931       +2     
  Partials      285      285
Impacted Files Coverage Δ
pkg/autoscaler/statserver/server.go 77.66% <0.00%> (-1.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3945364...ed6c6b9. Read the comment docs.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2022
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 40029f9 into knative:main Feb 23, 2022
@dprotaso dprotaso deleted the ggcr-fix branch February 23, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor approved these changes

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dprotaso @knative-prow-robot @mattmoor