Removes override of default periodSeconds value #12550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
do-not-merge/hold
Codecov Report
@@ Coverage Diff @@
## main #12550 +/- ##
==========================================
- Coverage 87.48% 87.48% -0.01%
==========================================
Files 195 195
Lines 9720 9718 -2
==========================================
- Hits 8504 8502 -2
Misses 931 931
Partials 285 285
Continue to review full report at Codecov.
|
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In #10992 we had introduced a workaround to prevent a delay in declaring a container ready due to the async nature of probe timers. Kubernetes introduced a fix in v1.21 (by trigger an immediate run of a readiness probe after startup), and now that we have 1.21 as a minimum version we no longer said workaround.
/assign @julz
/hold
for v1.21 release (though we should probably merge before the release)
Release Note