Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to GA version of PodDisruptionBudget #12548

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

psschwei
Copy link
Contributor

@psschwei psschwei commented Jan 24, 2022

Fixes #11488

Proposed Changes

As release v1.2 will require a minimum Kuberenetes version of 1.21, it's time to update the PodDisruptionBudget API.

/hold
for v1.21 release (though we should probably merge before the release)

Release Note

PodDisruptionBudget updated to v1 API

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 24, 2022
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #12548 (3985059) into main (f953230) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12548   +/-   ##
=======================================
  Coverage   87.48%   87.48%           
=======================================
  Files         195      195           
  Lines        9720     9720           
=======================================
  Hits         8504     8504           
  Misses        931      931           
  Partials      285      285           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f953230...3985059. Read the comment docs.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2022
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@psschwei
Copy link
Contributor Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2022
@psschwei
Copy link
Contributor Author

/test pull-knative-serving-upgrade-tests

@psschwei
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use v1 API for PodDisruptionBudget
3 participants