Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move our CI to GKE 1.21 #12509

Merged
merged 4 commits into from
Jan 20, 2022
Merged

Move our CI to GKE 1.21 #12509

merged 4 commits into from
Jan 20, 2022

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jan 14, 2022 •
edited
Loading

  • bump GKE to 1.21
  • disable the e2e scale test
Our minimum K8s version is now 1.21

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 14, 2022
@codecov
Copy link

codecov bot commented Jan 14, 2022 •
edited
Loading

Codecov Report

Merging #12509 (849dc30) into main (bd2a436) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12509      +/-   ##
==========================================
+ Coverage   87.43%   87.48%   +0.05%     
==========================================
  Files         195      195              
  Lines        9720     9720              
==========================================
+ Hits         8499     8504       +5     
+ Misses        934      931       -3     
+ Partials      287      285       -2
Impacted Files Coverage Δ
pkg/autoscaler/statforwarder/processor.go 94.44% <0.00%> (+5.55%) ⬆️
pkg/autoscaler/statforwarder/forwarder.go 96.29% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd2a436...849dc30. Read the comment docs.

@dprotaso
Copy link
Member Author

dprotaso commented Jan 14, 2022 •
edited
Loading

  • test/e2e.TestHPAAutoscaleUpDownUp was flakey before - curious if this test is timing sensitive as well

/retest

@nader-ziada
Copy link
Member

/test pull-knative-serving-istio-latest-no-mesh

to see if there is a flake there

@dprotaso
Copy link
Member Author

dprotaso commented Jan 14, 2022 •
edited
Loading

I have prior runs here: #12470 where I'm experimenting

Some observations

  • Single replica controller and removing chaos duck still causes the scale test to fail consistently even when removing all other tests
  • Further disabling leader election, so a single controller doesn't renew leases on a regular interval, does make it pass more regularly

So things generally seem 'slower' on a 1.21 cluster thus I opt'd to increase the scale test worker timeout to just unblock us. But that doesn't seem to help when we run all the tests with chaos duck.

@dprotaso
Copy link
Member Author

/retest

1 similar comment
@dprotaso
Copy link
Member Author

/retest

@dprotaso
Copy link
Member Author

I saw other PRs being able to push to GCR now - maybe there was an outage

/retest

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2022
@dprotaso dprotaso mentioned this pull request Jan 18, 2022
Merged
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2022
@dprotaso
Copy link
Member Author

Going to test some stuff
/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2022
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2022
@nak3 nak3 mentioned this pull request Jan 20, 2022
Merged
@dprotaso
bump GKE to 1.21
c77b765
@dprotaso
clean up comments
bedf8f9
@dprotaso
set a 60s stabilization window for the HPA e2e test
2fa132f 
With GKE 1.21 I'm seeing this test fail regularly. My assumption is the scaling algorithms have changed
or have different timings. So rather than rely on the default 5 minute window let's make adjustments more aggresively.
@dprotaso
disable TestToScaleN due to it being really flakey with GKE 1.21
849dc30
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 20, 2022
@dprotaso
Copy link
Member Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2022
@dprotaso
Copy link
Member Author

Upgrade tests seem flakey for some reason
/retest

@dprotaso
Copy link
Member Author

/test pull-knative-serving-upgrade-tests

1 similar comment
@dprotaso
Copy link
Member Author

/test pull-knative-serving-upgrade-tests

@evankanderson
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2022
@knative-prow-robot knative-prow-robot merged commit 30f5c96 into knative:main Jan 20, 2022
@dprotaso dprotaso deleted the gke-1.21 branch January 20, 2022 22:58
@dprotaso dprotaso mentioned this pull request Jan 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@evankanderson evankanderson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dprotaso @knative-prow-robot @nader-ziada @evankanderson