Allow tracking Cluster-scoped resources. #2304
Conversation
Previously we required namespace to be non-empty, but it never is for Cluster-scoped resources. This change elides validation for missing namespaces, assuming cluster-scoping.
Codecov Report
@@ Coverage Diff @@
## main #2304 +/- ##
==========================================
+ Coverage 64.35% 64.39% +0.04%
==========================================
Files 226 226
Lines 9628 9629 +1
==========================================
+ Hits 6196 6201 +5
+ Misses 3157 3155 -2
+ Partials 275 273 -2
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -333,15 +333,6 @@ func TestBadObjectReferences(t *testing.T) { | |||
| Name: "kaniko", | |||
| }, | |||
| match: "Kind", | |||
| }, { | |||
| name: "Missing Namespace", | |||
There was a problem hiding this comment.
could you please add a test into TestAllowedObjectReferences with the lack of a namespace?
|
bump followup test PR |
|
nm - it's here: #2306 |
Previously we required namespace to be non-empty, but it never is for Cluster-scoped resources.
This change elides validation for missing namespaces, assuming cluster-scoping.
/kind enhancement
Release Note
Docs