Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent case for "Deprecated" comments #2216

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Use consistent case for "Deprecated" comments #2216

merged 2 commits into from
Aug 17, 2021

Conversation

julz
Copy link
Member

@julz julz commented Aug 17, 2021

Not the most important thing ever (to say the least), but the canonical prefix to use for Deprecated: warnings in godoc is title case (and should be in its own paragraph).

Changes

  • 🧹 make deprecation comments use consistent case.

/kind cleanup

@julz
Use consistent case for "Deprecated" comments
b519042 
Not the most important thing ever, but the canonical string to use for
Deprecated warnings is case sensitive, and also it's nice to be
consistent.
@knative-prow-robot knative-prow-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release labels Aug 17, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 17, 2021
@codecov
Copy link

codecov bot commented Aug 17, 2021 •
edited
Loading

Codecov Report

Merging #2216 (b519042) into main (bf176d5) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

❗ Current head b519042 differs from pull request most recent head 001784a. Consider uploading reports for the commit 001784a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2216      +/-   ##
==========================================
- Coverage   65.99%   65.92%   -0.08%     
==========================================
  Files         220      220              
  Lines        9232     9229       -3     
==========================================
- Hits         6093     6084       -9     
- Misses       2869     2872       +3     
- Partials      270      273       +3
Impacted Files Coverage Δ
controller/controller.go 87.21% <ø> (ø)
metrics/exporter.go 84.09% <ø> (ø)
test/ha/ha.go 17.39% <ø> (ø)
tracing/zipkin.go 68.42% <ø> (ø)
tracker/interface.go 100.00% <ø> (ø)
webhook/configmaps/configmaps.go 86.31% <0.00%> (-0.15%) ⬇️
webhook/psbinding/psbinding.go 84.50% <0.00%> (-0.11%) ⬇️
...k/resourcesemantics/validation/validation_admit.go 93.25% <0.00%> (-0.08%) ⬇️
test/gcs/mock/mock.go 90.32% <0.00%> (-3.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35bcd16...001784a. Read the comment docs.

@julz
Copy link
Member Author

julz commented Aug 17, 2021

Surely not related

/retest

@julz
Copy link
Member Author

julz commented Aug 17, 2021

oh fun, that caused the linter to notice an actual use of a deprecated method (in a test).

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2021
@n3wscott
Copy link
Contributor

Deprecated: is the only key word that go uses, the capital version is incorrect 😄

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: julz, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@julz
Copy link
Member Author

julz commented Aug 17, 2021

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2021
@knative-prow-robot knative-prow-robot merged commit 50410e0 into knative:main Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julz @n3wscott @knative-prow-robot