Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not panic prober if report fetched too early (#5264) #5265

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Do not panic prober if report fetched too early (#5264) #5265

merged 1 commit into from
Apr 15, 2021

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Apr 15, 2021

Fixes #5264

Proposed Changes

  • Prober in upgrade tests calls t.Fatal instead of Panic

Release Note

Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 15, 2021
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Apr 15, 2021
@codecov
Copy link

codecov bot commented Apr 15, 2021 •
edited
Loading

Codecov Report

Merging #5265 (07b76d0) into main (fc115ae) will not change coverage.
The diff coverage is n/a.

❗ Current head 07b76d0 differs from pull request most recent head b6c3d70. Consider uploading reports for the commit b6c3d70 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5265   +/-   ##
=======================================
  Coverage   83.34%   83.34%           
=======================================
  Files         243      243           
  Lines        6879     6879           
=======================================
  Hits         5733     5733           
  Misses        797      797           
  Partials      349      349

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc115ae...b6c3d70. Read the comment docs.

@mgencur mgencur changed the title Do not panic prober if report fetched too early (#5264) [WIP] Do not panic prober if report fetched too early (#5264) Apr 15, 2021
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2021
@mgencur
Copy link
Contributor Author

mgencur commented Apr 15, 2021

The previous run shows the output when the error is actually thrown: build
I've just removed the induced error and it's ready.

@mgencur mgencur changed the title [WIP] Do not panic prober if report fetched too early (#5264) Do not panic prober if report fetched too early (#5264) Apr 15, 2021
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2021
vaikas
vaikas approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2021
@knative-prow-robot knative-prow-robot merged commit 92fb0f4 into knative:main Apr 15, 2021
cardil
cardil reviewed Apr 15, 2021
View reviewed changes
test/upgrade/prober/prober.go
t.Logf("All %d events propagated well", events)
eventErrs, eventCount, err := prober.Verify(ctx)
if err != nil {
t.Fatal("fetch error:", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. The error is already formulated. It would be better to just:

t.Fatal(err)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly. On the other hand, the error is more visible in the log. :

prober.go:69: fetch error: report fetched too early, receiver is in active state

vs.

prober.go:69: report fetched too early, receiver is in active state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cardil cardil cardil left review comments

@vaikas vaikas vaikas approved these changes

Assignees

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prober in upgrade tests panics when fetching report too early
4 participants
@mgencur @knative-prow-robot @cardil @vaikas