Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add t to Assert helpers from rekt #5210

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

n3wscott
Copy link
Contributor

@n3wscott n3wscott commented Apr 7, 2021

We had to make a breaking change in knative-extensions/reconciler-test#164, this PR lets us import that change.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 7, 2021
@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 7, 2021
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #5210 (e62feae) into main (5171353) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5210   +/-   ##
=======================================
  Coverage   83.31%   83.31%           
=======================================
  Files         243      243           
  Lines        6917     6917           
=======================================
  Hits         5763     5763           
  Misses        801      801           
  Partials      353      353           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5171353...e62feae. Read the comment docs.

@n3wscott
Copy link
Contributor Author

n3wscott commented Apr 7, 2021

When this lands I will fix:
- [ ] eventing-kafka-broker

  • eventing-rabbitmq

@lionelvillard
Copy link
Member

Kafka does not depend on reconciler-test (yet)

@n3wscott
Copy link
Contributor Author

n3wscott commented Apr 7, 2021

Kafka does not depend on reconciler-test (yet)

I mean eventing-kafka-broker

Oh, you are saying it might be the v1beta1 drop... got it.

Copy link
Contributor

@devguyio devguyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2021
@n3wscott
Copy link
Contributor Author

n3wscott commented Apr 7, 2021

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devguyio, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2021
@knative-prow-robot knative-prow-robot merged commit 533aeec into knative:main Apr 7, 2021
@pierDipi
Copy link
Member

pierDipi commented Apr 8, 2021

We use rekt in eventing-kafka-broker 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants