Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kn quickstart kind : A local registry is no longer created by default. #5789

Closed
wants to merge 1 commit into from
Closed

kn quickstart kind : A local registry is no longer created by default. #5789

wants to merge 1 commit into from

Conversation

yanggangtony
Copy link

Fixes #5778.

image

The latest code shows that

A local registry is no longer created by default.
To create a local registry, use the --registry flag.

@netlify Netlify
Copy link

netlify bot commented Dec 5, 2023 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0f0bb60
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/656f3863933edb0008b14db6
😎 Deploy Preview https://deploy-preview-5789--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yanggangtony
Once this PR has been reviewed and has the lgtm label, please assign salaboy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 5, 2023

Welcome @yanggangtony! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 5, 2023
@ReToCode
Copy link
Member

ReToCode commented Dec 6, 2023

/hold see #5778 (comment)

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 6, 2024
@yanggangtony yanggangtony deleted the fix-quickstart-kind-registry branch March 6, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbanugo pmbanugo Awaiting requested review from pmbanugo

@skonto skonto Awaiting requested review from skonto

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A local registry is no longer created by default.
2 participants
@yanggangtony @ReToCode