-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shellcheck warnings in hack/build.sh script #1860
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1860 +/- ##
=======================================
Coverage 79.62% 79.62%
=======================================
Files 179 179
Lines 13927 13927
=======================================
Hits 11090 11090
Misses 2070 2070
Partials 767 767 ☔ View full report in Codecov by Sentry. |
Hi @xiangpingjiang. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
74f4c0d
to
239c1fa
Compare
/retest |
239c1fa
to
e897eb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding hold for @rhuss to have a look as well. Otherwise it looks good to me. Thanks for accommodating the review feedback promptly!
/lgtm
/hold
Some minor comments, otherwise looks good to me. Thanks @xiangpingjiang ! |
|
Signed-off-by: pingjiang <[email protected]>
e5bd9cf
to
e74af95
Compare
/retest |
@rhuss , Thanks for your reviews, I corrected your comments, could you review my latest code ? |
Thanks! Looks good to me, thanks a lot for patience :-) /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, rhuss, xiangpingjiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Description
Changes
Reference
Fixes #1859
Release Note