-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade deprecated v1alpha1 DomainMapping API to newer one #1856
Conversation
Hi @xiangpingjiang. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xiangpingjiang: 0 warnings.
In response to this:
Description
Changes
Reference
Fixes #1854
Release Note
- 🐣 Upgrade deprecated v1alpha1 DomainMapping API to newer one
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/ok-to-test |
/retest |
Signed-off-by: pingjiang <[email protected]>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xiangpingjiang!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, xiangpingjiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1856 +/- ##
=======================================
Coverage 79.64% 79.64%
=======================================
Files 179 179
Lines 13938 13938
=======================================
Hits 11101 11101
Misses 2070 2070
Partials 767 767
☔ View full report in Codecov by Sentry. |
Description
Changes
Reference
Fixes #1854
Release Note