Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix tagging of kn container image for latest releases #1792

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Mar 21, 2023

Description

Changes

  • 🐛 fix: Fix tagging of kn container image for latest releases

Reference

Fixes knative/test-infra#2593

Release Note

Fix tagging of `kn` container image for latest releases

/cc @dprotaso @knative/productivity-writers

@knative-prow knative-prow bot requested a review from dprotaso March 21, 2023 19:04
@knative-prow
Copy link

knative-prow bot commented Mar 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 21, 2023
@knative knative deleted a comment from knative-prow bot Mar 21, 2023
@dsimansk
Copy link
Contributor Author

/cherry-pick release-1.9

@knative-prow-robot
Copy link
Contributor

@dsimansk: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7586217) 79.87% compared to head (f26650d) 79.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1792   +/-   ##
=======================================
  Coverage   79.87%   79.87%           
=======================================
  Files         174      174           
  Lines       13593    13593           
=======================================
  Hits        10858    10858           
  Misses       1992     1992           
  Partials      743      743           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dsimansk
Copy link
Contributor Author

/retest

@dprotaso
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2023
@knative-prow knative-prow bot merged commit c21e660 into knative:main Mar 22, 2023
@knative-prow-robot
Copy link
Contributor

@dsimansk: new pull request created: #1795

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Older client's dot release image is tagged as latest
3 participants