Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing some linter issues #1777

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Fixing some linter issues #1777

merged 1 commit into from
Feb 15, 2023

Conversation

rhuss
Copy link
Contributor

@rhuss rhuss commented Feb 15, 2023 •
edited by dsimansk
Loading

Release Note

 Fix issue with newer linter version

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 15, 2023
@codecov
Copy link

codecov bot commented Feb 15, 2023 •
edited
Loading

Codecov Report

Base: 79.87% // Head: 79.88% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (05f4479) compared to base (dfc3c1e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1777   +/-   ##
=======================================
  Coverage   79.87%   79.88%           
=======================================
  Files         174      174           
  Lines       13595    13594    -1     
=======================================
  Hits        10859    10859           
+ Misses       1993     1992    -1     
  Partials      743      743
Impacted Files Coverage Δ
pkg/printers/tablegenerator.go 100.00% <100.00%> (ø)
pkg/errors/factory.go 100.00% <0.00%> (+2.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dsimansk
Copy link
Contributor

Thanks!

/approve
/lgtm

@knative-prow
Copy link

knative-prow bot commented Feb 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023
@knative-prow knative-prow bot merged commit badd909 into knative:main Feb 15, 2023
scottmason88 added a commit to scottmason88/client that referenced this pull request Feb 16, 2023
@scottmason88
remove factory_test.go changes, already fixed in knative#1777
1d24121
@dsimansk dsimansk added the kind/bug Categorizes issue or PR as related to a bug. label Feb 16, 2023
knative-prow bot pushed a commit that referenced this pull request Feb 17, 2023
@scottmason88
Fixing errors related to Go 1.20 (#1779)
8a2ed4c 
* Fix the errors Go 1.20 introduced

* Didn't remove comments

* New version of service.go

* add linter directive to allow for use of math/rand

* Added to changelog

* fix issue with tablegenerator.go

* remove factory_test.go changes, already fixed in #1777

* Revert changelog changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@itsmurugappan itsmurugappan Awaiting requested review from itsmurugappan

@maximilien maximilien Awaiting requested review from maximilien

Assignees

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhuss @dsimansk