Added support for mounting EmptyDir volume type

[vyasgun]

Description

Added support for mounting EmptyDir volume type

Changes

• Added parsing for emptyDir volume type, medium type, and size limit

Reference

Fixes #1633

Release Note

Add support for mounting EmptyDir volumes

[knative-prow]

@vyasgun: 0 warnings.

In response to this:

Description

Added support for mounting EmptyDir volume type

Changes

• Added parsing for emptyDir volume type, medium type, and size limit

Reference

Fixes #1633

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #1679 (b692085) into main (94a5352) will increase coverage by 0.19%.
The diff coverage is 67.50%.

@@            Coverage Diff             @@
##             main    #1679      +/-   ##
==========================================
+ Coverage   79.49%   79.69%   +0.19%     
==========================================
  Files         171      173       +2     
  Lines       12969    13264     +295     
==========================================
+ Hits        10310    10571     +261     
- Misses       1941     1963      +22     
- Partials      718      730      +12     

Impacted Files	Coverage Δ
pkg/kn/flags/podspec_helper.go	81.87% <65.17%> (-0.56%)	⬇️
pkg/kn/flags/podspec.go	77.68% <100.00%> (+0.17%)	⬆️
pkg/kn/commands/broker/create.go	69.64% <0.00%> (-1.41%)	⬇️
pkg/kn/commands/broker/broker.go	100.00% <0.00%> (ø)
pkg/kn/commands/broker/update.go	86.36% <0.00%> (ø)
pkg/kn/commands/broker/delivery_option_flags.go	100.00% <0.00%> (ø)
pkg/eventing/v1/client_mock.go	92.75% <0.00%> (+0.81%)	⬆️
pkg/eventing/v1/client.go	91.00% <0.00%> (+3.73%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94a5352...b692085. Read the comment docs.

[dsimansk]

I think with the current approach the PR is mixing --mount and --volume flag functionality. Moreover what about more simplistic approach would be better for emptyDir. I'd expect most usage is with default emptyDir: {}. We don't necessarily need to cover Medium and SizeLimit parameters at first.

However, if the decision is to have those detailed settings. Any additional parameters should be parsed in --volume flag.

My suggestion for handling:

• Use of --mount /path=ed:myEmptyVol results in:
  • Creation of volume stanza with default config {}
  • Similarly to the following When a configmap or a secret is specified, a corresponding volume is automatically generated.

volumes:
  - name: myEmptyVol    
    emptyDir: {}

[dsimansk]

/retest

[vyasgun]

@dsimansk Thanks for the review. The memory and size limit syntax is according to #1633 (comment). I will add the additional functionality to the --volume flag and simplify --mount .

[dsimansk]

@dsimansk Thanks for the review. The memory and size limit syntax is according to #1633 (comment). I will add the additional functionality to the --volume flag and simplify --mount .

OK, I see. :) It still feels like too granular option to my taste. However, let's have it in --volume flag. That should be fine.

[dsimansk]

@vyasgun there's one issue with current volume creation that I've stumped upon. By default we enforce readOnly: true, that's probably good and desired for ConfigMaps and Secrets. However, it'll be problematic for empty dir and PVC since those might be very well expected to have write access.

https://github.com/knative/client/blob/main/pkg/kn/flags/podspec_helper.go#L504

[dsimansk]

/approve
/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dsimansk]

/kind feature