Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): update i18n/jp for 2.2.0 release #869

Merged
merged 3 commits into from
Jul 14, 2022
Merged

fix(i18n): update i18n/jp for 2.2.0 release #869

merged 3 commits into from
Jul 14, 2022

Conversation

t3hmrman
Copy link
Contributor

This commit contains translations for the new terms entered before release 2.2.0

@t3hmrman t3hmrman mentioned this pull request Jul 14, 2022
@knadh knadh merged commit c742c91 into knadh:master Jul 14, 2022
@t3hmrman
Copy link
Contributor Author

OK this should be ready to go now, just a couple notes on what was wrong for others:

  1. New translations were added so those have been translated
  2. Language name should have been "Japanese" (日本語) but was English (in Japanese)
  3. English replacements were translated (ex {num})

Both 2 & 3 were mistakes that I should have noticed earlier 🙇

@t3hmrman t3hmrman deleted the fix/i18n-jp-for-release-2.2.0 branch July 14, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants