-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent app from update #326
Comments
Updates are opt-in. Unless you pull the latest image, you can keep running a fixed |
Ah, you mean update checks. Makes sense to add this. |
Thanks, this option is appreciated ... but the implementation has a loophole. This is something that really needs to be implemented as a CLI flag/config file option so that it can be disabled before the first run, not after! With this implementation there is a bootstrapping issue in that it can only be disabled after its already been run. |
Another option if you are adamant about keeping it out of the system config file would be to default it to off. 95a81d1#diff-939acd018b931292330e519becd8d003ed0dd20c5e42de62ec3d37553698739aR181 |
The toggle on the UI is more accessible for most users. Defaulting to off means most users would end up missing out on updates. Right now, the update check happens a) on boot b) every 24 hours. If "check on boot" is disabled, then listmonk will only check for updates after 24 hours of boot, which should solve this problem. This can be done trivially. |
This commit disables the automatic upe check thappens immediately on boot, giving users an opportunity disable it from the settings UI before any remote requests are initiated. Tupdate checks happen every 24 houfter boot. Ref: #326
I'm behind a proxy where I not have access inside my cluster to internet.
The text was updated successfully, but these errors were encountered: