Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent app from update #326

Closed
brunowego opened this issue Apr 19, 2021 · 6 comments
Closed

Prevent app from update #326

brunowego opened this issue Apr 19, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@brunowego
Copy link
Contributor

I'm behind a proxy where I not have access inside my cluster to internet.

@brunowego brunowego changed the title Prevent app to update Prevent app from update Apr 19, 2021
@mr-karan
Copy link
Collaborator

Updates are opt-in. Unless you pull the latest image, you can keep running a fixed listmonk version.

@brunowego
Copy link
Contributor Author

brunowego commented Apr 20, 2021

This is a great feature! But, just for this cases where not have access to the internet, a option to disable this, will be great!

Screen Shot 2021-04-20 at 12 58 27 PM

Thanks for your attention!

@knadh knadh added the enhancement New feature or request label Apr 21, 2021
@knadh
Copy link
Owner

knadh commented Apr 21, 2021

Ah, you mean update checks. Makes sense to add this.

@alerque
Copy link
Contributor

alerque commented May 17, 2021

Thanks, this option is appreciated ... but the implementation has a loophole. This is something that really needs to be implemented as a CLI flag/config file option so that it can be disabled before the first run, not after! With this implementation there is a bootstrapping issue in that it can only be disabled after its already been run.

@alerque
Copy link
Contributor

alerque commented May 17, 2021

Another option if you are adamant about keeping it out of the system config file would be to default it to off.

95a81d1#diff-939acd018b931292330e519becd8d003ed0dd20c5e42de62ec3d37553698739aR181

@knadh
Copy link
Owner

knadh commented May 17, 2021

The toggle on the UI is more accessible for most users. Defaulting to off means most users would end up missing out on updates.

Right now, the update check happens a) on boot b) every 24 hours. If "check on boot" is disabled, then listmonk will only check for updates after 24 hours of boot, which should solve this problem. This can be done trivially.

knadh added a commit that referenced this issue May 23, 2021
This commit disables the automatic upe check thappens immediately
on boot, giving users an opportunity disable it from the settings UI
before any remote requests are initiated. Tupdate checks happen
every 24 houfter boot.

Ref: #326
@kmohrf kmohrf mentioned this issue Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants