Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lists - sorting, selecting, and importing. Various bugs. #1076

Closed
MaximilianKohler opened this issue Dec 1, 2022 · 8 comments
Closed

lists - sorting, selecting, and importing. Various bugs. #1076

MaximilianKohler opened this issue Dec 1, 2022 · 8 comments
Assignees
Labels
bug Something isn't working needs-investigation Potential bug. Needs investigation

Comments

@MaximilianKohler
Copy link
Contributor

MaximilianKohler commented Dec 1, 2022

EDIT: the fix is to refresh (F5) the page #1076 (comment)

Version:

  • listmonk: v2.3.0
  • OS: ubuntu

Step 1:

I created a new list, and sorted by "created". It should be at the top.
lists 01

It's not; it's on page 2:
lists 02

Step 2:

I click "import subscribers". I click in the "lists" box. There should be a popup of all the lists to select from, but there's not:
lists 03

Step 3:

I click the "x" to remove the current list:
lists 04

Step 4:

I click in the box again, and only the one list shows up.
lists 05

Step 5:

After importing them, it still doesn't show the other lists for me to add them to:
lists 06

When I navigated to the "import subscribers" page /admin/subscribers/import, still only that one list would show up.

I instead navigated to it by clicking "import subscribers" on another list, and all the lists except that one showed up.

If I open a new tab and navigate to the "import subscribers" page /admin/subscribers/import, everything shows up. BUT if I first go to "lists" /admin/lists and sort by "created", the same bug happens with the list being on the 2nd page, then not showing up at all on /admin/subscribers/import.

After separately importing the same list of 500 subscribers to the other list I wanted to add them to, the "Next 03-500" list now displays at the top of page 1 when sorting by "created".

UPDATE:

The next day, for the new list (Next 04), it was similar, but on Step 2 only the "next all" list showed up when clicking in the box, which is the 2nd list I was trying to add the previous one to (and which I did add it to). And after successful import, and sorting by "newest created" it's still on page 2.

It is also not in the list at all on my campaign page /admin/campaigns/40 where I'm trying to select a list to send the campaign to.

@MaximilianKohler MaximilianKohler added the bug Something isn't working label Dec 1, 2022
@knadh knadh added the needs-investigation Potential bug. Needs investigation label Dec 5, 2022
@knadh knadh closed this as completed in 49f20f3 Dec 25, 2022
@knadh
Copy link
Owner

knadh commented Dec 25, 2022

  1. Sorting is fixed.

  2. Confused about what's happening with the popup list. Once lists are created, the import page has to be refreshed once (if it was left open) for it to be fetched again. Also, a list that has already been selected will not show in the popup again, so if there's only one list, and it's already selected, there will be no popup.

@MaximilianKohler
Copy link
Contributor Author

MaximilianKohler commented Dec 25, 2022

  1. I suspect it may have been fixed by the sorting fix. But an easy way to demonstrate the bug is to search one list name. If only that one list shows up in the results, it will then be the only list that gives a result on the "import subscribers" and "campaign" pages (in the boxes you click on to select a list).

Easy fix is refreshing the page.

There are even benefits to the current behavior (easy/quick access to the specific lists you want), so I wouldn't mind it staying as is.

@MaximilianKohler
Copy link
Contributor Author

  1. Sorting is fixed.

/admin/subscribers/lists/152 if you click on "status" it doesn't sort by unsubscribed and blocklisted.

/admin/lists if you click on "subscribers" it doesn't sort accurately.

@MaximilianKohler
Copy link
Contributor Author

@knadh could you reopen this issue due to my last comment on April 7?

@knadh
Copy link
Owner

knadh commented Nov 11, 2023

Looks like these got fixed at some point. Sorting in the above two scenarios work correctly on the latest version.

@knadh knadh closed this as completed Nov 11, 2023
@MaximilianKohler
Copy link
Contributor Author

I'm on the latest version (v2.5.1) and still experiencing it:

subs sort 1
Reversed:
subs sort 2
Last page (15):
page 15
sort by status 1
Reverse status:
reverse sort

@knadh knadh reopened this Nov 11, 2023
@knadh knadh closed this as completed in c59825f Nov 12, 2023
@knadh
Copy link
Owner

knadh commented Nov 12, 2023

Ah, this turned out to be quite tricky. Don't know how I missed this earlier. Fixed now in c59825f

Thanks for illustrating the issue in detail @MaximilianKohler

@MaximilianKohler
Copy link
Contributor Author

Hey knadh, thanks for all the recent updates! I just noticed that in /admin/lists I created a list named test2 and when I search for test I can't find it. It only shows if I type in test2. It looks like the search only recognizes whole words. IE: test does show test-list and bounce-test-list .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-investigation Potential bug. Needs investigation
Projects
None yet
Development

No branches or pull requests

2 participants