Update keycap name for non-US backslash in Mac/Types.hs #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postylem
changed the title
slotThe
reviewed
Nov 16, 2023
This was referenced Nov 16, 2023
Closed
In addition, change the old name, `KeyNonUSBackslash`, to `Key102nd`. This matches the name defined in `src/KMonad/Keyboard/Keycode.hs` (the keycode which is assigned the alias 'nubs').
|
Thanks! |
|
@slotThe I also had to modify the keymap/template/apple.kbd to work with my ISO macbook pro (shifting things over and adding this one additional key). Would it be helpful to submit a PR to add an keymap/template/apple-ISO.kbd ? |
|
I think that would be very helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
KeyNonUSBackslashtoKey102ndto match the name defined insrc/KMonad/Keyboard/Keycode.hs(they keycode which is assigned alias 'nubs').Since
Key102ndis assigned the the 'nubs' keycode (aka '102d', or 'lsgt') in Keycode.hs, it seems it should also be the keycode to which mac keycode (0x7, 0x64) (that is, the § key to the left of 1 on a UK-layout ISO keyboard) is assigned.