Feature/win key repeat #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture/win-key-repeat
|
Just pinging known Windows users: @6gk @whitbur @MaxGyver83 |
|
ooo interesting
will check it out tomorrow!
|
|
I have tested it: (An undesired side effect of #252: When I press and hold the A key which is a tap-hold-next-release+layer-toggle layer 3 key, the according layer 3 key is being repeated.) |
|
Works really well at first try - thank you! The easy method of changing the repeat rate is much appreciated too. |
|
Very good, all automated tests are passing, all actual users seem pleased. Trigger pulled. |
roubaobaozi
pushed a commit
to roubaobaozi/kmonad
that referenced
this pull request
Apr 16, 2023
* Bump resolver to match available GHC in nix * First attempt at key-repeat in windows * Hooking up the parsers and preparing testing * Changed micro to milli-seconds * First attempt at key-repeat in windows * Hooking up the parsers and preparing testing * Changed micro to milli-seconds * Fixed bug * Modified testing values * Fixed error in parser * Made the test a little bit more sane
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I have this working now. The way it's currently implemented, you may optionally provide 2 arguments to
send-event-sink(it's optional whether you provide them, but when you provide them you must provide 2) that determine thedelayand therateof the key repeat.delay- How many ms before a key starts repeatingrate- How many ms between each repeat eventI only have Windows running in a VirtualBox, so my testing setup is very limited. Let's try to get some people to try it and if nothing blows up we merge this in?