NixOS module: Optionally make systemd group for multiple config services #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nix/module-base.nix
Outdated
Comment on lines
66
to
67
| # If only one config file is supplied, unify all kmonad units under a target | ||
| make-group = (length cfg.configfiles + length cfg.optionalconfigs) > 1; | ||
| make-group = cfg.make-group && (length cfg.configfiles + length cfg.optionalconfigs) > 1; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Good pickup! I'm pretty sure it's the comment that's wrong, as it doesn't make sense to make a group if there's only a single service.
I've updated the comment so it's consistent with what the code does (and used to do).
|
Looks reasonable to me; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to switch off the service for my bluetooth keyboard when it's disconnected, but when the services are grouped they all shut down.
This change optionally stops the service group being created, allowing them to be started/stopped individually.