-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panic on Writer.Close, runtime error: index out of range #15
Comments
Thanks for the report - I will investigate at once! |
Can you confirm that |
Yes, and unfortunately there are two indexes used on that line. I'm not sure which is out of range. |
@maruel has found this bug too https://code.google.com/p/chromium/issues/detail?id=552697#c4 . |
From the other report it is clear that it is I am of course continuing work on this. |
OK. Are you checking returned error values? If you call Write after a write has already failed (in case of the chrominum bug) I can see this error occurring.
Both are of course bugs, and will be fixed - I just want to be sure I haven't overlooked anything. |
We reproduce in this case:
I was planning try to write a regression test before even bothering you about this but too late, eh. :) |
@toffaletti (shameless) plug for panicparse to make your stack traces shorter. |
Errors from the underlying writer was not being forwarded/returned, so that is now done, and tests have been added to test that functionality Fixes #15
Thanks for helping identify this issue. I have merged the fix after testing. |
In our code I don't control whether Write is called again after an error because our write is essentially |
Unfortunately I don't have a test to reproduce this, but over hundreds of thousands of calls we started seeing a few of these panics:
We never saw this before I updated our snapshot on Nov 2nd. The previous update was Sep 8th.
The text was updated successfully, but these errors were encountered: