Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Explore / propose strategy (if applicable, MVP implementation) for EVM Precompiled contract -> 0x04 identity #360

Closed
Eikix opened this issue Dec 9, 2022 · 1 comment · Fixed by #392
Closed

feat: Explore / propose strategy (if applicable, MVP implementation) for EVM Precompiled contract -> 0x04 identity #360

Eikix opened this issue Dec 9, 2022 · 1 comment · Fixed by #392
Assignees
@jobez
Labels
Context: isolated no previous knowledge of the codebase required
Milestone
Kakarot v0.3

Comments

@Eikix
Copy link
Member

Eikix commented Dec 9, 2022

Feature Request

Describe the Feature Request

feat: Explore / propose strategy (if applicable, MVP implementation) for EVM Precompiled contract -> 0x04 identity

https://www.evm.codes/precompiled
@Eikix Eikix added Difficulty: hard Context: isolated no previous knowledge of the codebase required labels Dec 9, 2022
@Eikix Eikix moved this to 🆕 New in Kakarot's Project Management Dec 9, 2022
@Eikix Eikix added this to the Kakarot v0.3 milestone Dec 9, 2022
@jobez
Copy link
Contributor

jobez commented Dec 16, 2022

⚡ i can implement this

@jobez jobez mentioned this issue Dec 22, 2022
Merged
7 tasks
ClementWalter pushed a commit that referenced this issue Dec 23, 2022
@jobez @AbdelStark
Feature/precompile identity (#360) (#392)
ed8cf97 
## Pull request type

Please check the type of change your PR introduces:

- [ ] Bugfix
- [X] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):

## What is the current behavior?

call, staticcall, and delegatecall opcodes are not dispatching to
precompile address 0x04, identity

Resolves #360 

## What is the new behavior?

Per earlier discussion with @ClementWalter 

- call, staticcall, and delegatecall opcodes are checking if address is
within a precompile range
- if so, it delegates out to Precompile.run, which further dispatches
for address to precompile implementation
- it passes the precompile implementation a 'stopped' context to which
the implementation of a precompile is expected to update the return data
with its result

## Other information

Time spent on this PR:  1 day(s)

Co-authored-by: Abdel @ StarkWare <[email protected]>
Repository owner moved this from 🆕 New to ✅ Done in Kakarot's Project Management Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jobez jobez

Labels
Context: isolated no previous knowledge of the codebase required
Projects
Kakarot's Project Management
Archived in project
Milestone
Kakarot v0.3
Development

Successfully merging a pull request may close this issue.

Feature/precompile identity (#360) jobez/kakarot
2 participants
@jobez @Eikix