Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libtribler recipe #405

Closed
wants to merge 2 commits into from
Closed

Conversation

ontwikkelaar
Copy link

Add a recipe for libtribler. Tribler can be found at https://github.com/Tribler/tribler.


# Clone repo so all submodules are included:
cd $BUILD_PATH/libtribler
git clone --recursive https://github.com/tribler/tribler.git tribler-git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't the recipe use the zipball from github? Aka https://github.com/Tribler/tribler/archive/devel.zip
Otherwise, please enhance the recipe to prevent downloading /cloning the repo everytime :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with the archive is that it doesn't download the git submodules. I'll have a look at this and perhaps package the submodules separately, probably the preferred option, or see if I can do something about the cloning.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tribler uses git submodules for Dispersy and pymdht. It then makes imports such as Tribler.dispersy.etc. and something similar for pydmht. So it expects these two modules to be present inside libtribler (and not externally). Using the direct archive from GitHub means that these submodules will be missing, like Darsestheus stated.
The approach in my latest commit is that libtribler is recursively cloned (as to include submodules) to $PACKAGES_PATH/libtribler. This is only done if it hasn't been cloned before. If it has been cloned before than a git pull command is executed instead to fetch the latest changes. In case any changes were fetched (it checks this by comparing the latest commit hash before and after pulling), or in the case that the build directory is empty, the libtribler directory (in $PACKAGES_PATH/libtribler) is copied to the build directory (in $BUILD_libtribler).

…. Alsp stores a cache of libtribler in packages as well.
@brussee
Copy link
Contributor

brussee commented Jan 4, 2016

Picking up this work for my master thesis project.

I need the following missing recipes for Tribler; so they need to be recreated for the new p4a-toolchain:

  • ffmpeg | libav-tools,
  • libsodium,
  • libnacl,
  • sqlite3
  • apsw {sqlite3},
  • cherrypy3,
  • cryptography,
  • decorator,
  • feedparser,
  • leveldb | plyvel,
  • py-leveldb {leveldb},
  • boost
  • libtorrent {boost},
  • openssl,
  • m2crypto {openssl},
  • netifaces,
  • pil {jpeg, png},
  • requests,
  • twisted,

@brussee
Copy link
Contributor

brussee commented Apr 27, 2016

All required recipes mentioned above are now done.
This PR is superseded by #726 so can be closed.

@inclement inclement closed this Apr 27, 2016
@inclement
Copy link
Member

@brussee Thanks for all these, and I'm sorry for the delay with merging them, I've had less time than I hoped for p4a recently but expect to be able to look at everything properly soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants