Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @Meow as contributor for Discord-Flavored Markdown #446

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

liamwhite
Copy link
Contributor

(Commits were tagged with @Meow as co-author, but automatic changelog generation script only pulled my username)

@Meow
Copy link
Contributor

Meow commented Jul 12, 2024

I was the one who originally wrote the relevant code for the contribution in question, as it was used for the projects Liam and I work on. Liam has adapted it to be mergeable to upstream, however it is still largely based off my work, so I think it's only fair we're both credited. It also didn't occur to me sooner to try to put those changes upstream, since I was not sure of the utility they could have for the larger comrak user base, it was Liam's idea that they are useful enough for that.

@kivikakk kivikakk merged commit 9f4d391 into kivikakk:main Jul 13, 2024
20 of 21 checks passed
@kivikakk
Copy link
Owner

Thank you! I've made the parallel change to the 0.25.0 release on GitHub. :)

@Meow
Copy link
Contributor

Meow commented Jul 13, 2024

Thank you very much! :)

@liamwhite liamwhite deleted the code-attribution branch July 13, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants