Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ [Release] Version 2.2.3 #753

Merged
merged 5 commits into from
Jun 9, 2020
Merged

⬆️ [Release] Version 2.2.3 #753

merged 5 commits into from
Jun 9, 2020

Conversation

kittinunf
Copy link
Owner

@kittinunf kittinunf commented Jun 7, 2020

Description

This is mainly to support #747 and small bug fixes. This also supersedes #731 (let me handle that in this PR 🙇 )

Type of change

Check all that apply

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (a change which changes the current internal or external interface)
  • This change requires a documentation update
  • New version

How Has This Been Tested?

In case you did not include tests describe why you and how you have verified the
changes, with instructions so we can reproduce. If you have added comprehensive
tests for your changes, you may omit this section.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if necessary
  • My changes generate no new compiler warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Inspect the bytecode viewer, including reasoning why

@kittinunf kittinunf self-assigned this Jun 7, 2020
@codecov
Copy link

codecov bot commented Jun 7, 2020

Codecov Report

Merging #753 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #753   +/-   ##
=========================================
  Coverage     72.71%   72.71%           
  Complexity      301      301           
=========================================
  Files            61       61           
  Lines          1510     1510           
  Branches        205      205           
=========================================
  Hits           1098     1098           
  Misses          311      311           
  Partials        101      101           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3323c96...8d43f6f. Read the comment docs.

Copy link
Collaborator

@iNoles iNoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me.

@kittinunf
Copy link
Owner Author

Thanks!

@kittinunf kittinunf changed the title [Release] Version 2.2.3 ⬆️ [Release] Version 2.2.3 Jun 9, 2020
@kittinunf kittinunf merged commit 85d8a8d into master Jun 9, 2020
@kittinunf kittinunf deleted the kv/release-2.2.3 branch June 9, 2020 07:45
@kittinunf kittinunf restored the kv/release-2.2.3 branch June 9, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants