Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep previous selection of new structure type if possible #6120

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

oliver-stoehr
Copy link
Collaborator

Keep the previous selection in the dialog for adding new structures in the metadata editor. If the dialog is opened consecutively, the same value doesn't have to be reentered.
The selection is reset, when the previous value is not allowed on the current structure/position.
Resolves #5933.

@andre-hohmann
Copy link
Collaborator

Thanks a lot! This is an important improvement for the ones who are working intensively in the metadata editor.

In my tests, it works fine for structure elements and metadata of structure elements for one process.
If the metadata editor is opened for a new process or is reopened for the same process, the value of the structure element or metadata has to be chosen again.

@BartChris , @apiller , @subhhwendt , @matthiaskissler , @aetherfaerber, @Westedt: what do you think?

  • Should the metadata editor "remember" the last chosen value of a structure element and metadata for all processes until the user logs out?
  • Or is it the correct behavior, that the value is "remembered" only until the metadata editor is closed?

@matthiaskissler
Copy link

I think it would be easiest if the editor remembers the value only as long as the process is open (it would be an improvement nevertheless).

@andre-hohmann
Copy link
Collaborator

@matthiaskissler : Thanks for the feedback!
My colleagues support the current functionality, too.

Copy link
Collaborator

@andre-hohmann andre-hohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a review from the users' perspective, not the technical one.
In my opinion, it works correctly - thanks a lot!

In case that further functionality is required (see #6120 (comment)), another issue should be created with the necessary requirements.

Copy link
Collaborator

@henning-gerhardt henning-gerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion only which can be resolved even on an other way.

@solth solth merged commit aeb57d1 into kitodo:master Jul 29, 2024
5 checks passed
@oliver-stoehr oliver-stoehr deleted the 5933 branch August 7, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remember the last added structure element
5 participants