Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow checking for existence without showing Biometry UI #384

Closed
wants to merge 2 commits into from

Conversation

Marcocanc
Copy link
Contributor

We can check if biometry protected items exist without prompting for authentication by disabling Authentication UI and checking for errSecInteractionNotAllowed

@Marcocanc Marcocanc changed the title Allow checking for contains without showing Biometry UI Allow checking for existence without showing Biometry UI Jun 12, 2018
@Marcocanc
Copy link
Contributor Author

Any chance to get this merged, @kishikawakatsumi?

@james-rant
Copy link

This looks like a good addition to me. Would be good to see it merged.

@codecov
Copy link

codecov bot commented Sep 23, 2019

Codecov Report

Merging #384 into master will decrease coverage by 44.21%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #384       +/-   ##
===========================================
- Coverage   90.83%   46.61%   -44.22%     
===========================================
  Files           1        1               
  Lines        1767     1757       -10     
===========================================
- Hits         1605      819      -786     
- Misses        162      938      +776
Impacted Files Coverage Δ
Lib/KeychainAccess/Keychain.swift 46.61% <100%> (-44.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f361408...ebab280. Read the comment docs.

@kishikawakatsumi
Copy link
Owner

Thanks for the PR! This PR is superseded #451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants