Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically update app proxy #42

Conversation

charlienaud
Copy link

Since @shopify/cli version 3.49.0 there is an extra appProxy parameter in the appUpdate mutation.
https://github.com/Shopify/cli/blob/3.49.0/packages/app/src/cli/api/graphql/update_urls.ts#L4

Here is a proposal to modify the updateDashboard script to allow automatically updating the app proxy configuration.

Requires @shopify/cli >= 3.49.0
@kinngh
Copy link
Owner

kinngh commented Nov 14, 2023

While I'm aware of this, every developer has their own proxy url and hiding it behind a script is a very bad idea. Also, this is going to promote newer / unsuspecting developers to use the same proxy across multiple apps and across multiple developers and cause a lot of issues.

Closing PR.

@kinngh kinngh closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants