-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pull Request] Implement local SSL proxy for running the app with a .test domain instead of ngrok #21
Conversation
@@ -37,3 +37,7 @@ yarn-error.log* | |||
|
|||
# vercel | |||
.vercel | |||
|
|||
#vscode | |||
.vscode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.vscode
contains snippet library and cannot be ignored.
"ssl:install": "mkcert -install", | ||
"ssl:create": "node _developer/generateSSL.js", | ||
"tunnel": "local-ssl-proxy --config proxy-config.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary complications. it's going to be really difficult to explain to people who don't understand what's happening under the hood and later for them to debug it.
Also, while understandable why you potentially see running a local proxy server instead of using The repo should be What I'd recommend is to fork the repo and keep it synced to this repo so it's up to date while maintaining your preferred dx. |
Hello @kinngh, I hope this message finds you well. Firstly, I am grateful for reviewing my pull request. Your feedback is greatly appreciated, and I value your insights on improving the developer experience. I understand your concern about the approach I took with running a local proxy server instead of using ngrok. However, I fully agree that ngrok provides a convenient and beginner-friendly solution for tunneling services. I initially implemented it to cater to the needs of advanced users who prefer a more robust experience. However, my intention was also to provide an additional feature that could benefit advanced users without affecting the experience of beginners. By introducing the option to use a local proxy server, developers who are more experienced and comfortable with custom setups could enjoy a super fast loading speed and enhanced debugging capabilities. It is important to note that ngrok has some limitations, especially in custom subdomains. Custom subdomains are only available for premium users, meaning non-premium users would have to change the application URLs each time they use ngrok. I guess this is why you build Once again, thank you for your valuable feedback. I am open to any other suggestions or modifications you may have about this pull request. Again, your guidance and expertise are precious. |
About As far as senior devs are concerned, I'd say simplicity is the key. I like to consider myself a senior dev and other devs with the senior title around me have agreed while your suggested approach is great, it doesn't benefit enough to be working great with other devs who aren't as experienced and this approach will cause. There's enough forks of the repository with changes and libraries swapped out and I appreciate all of them. The idea of my repos is:
I personally prefer Cloudflare Tunnels but |
Thanks, @kinngh. I completely understand your viewpoint on simplicity. |
This pull request introduces the implementation of a local SSL proxy to facilitate running the application using a .test domain. Currently, the app relies on Ngrok for tunneling and exposing the local server to the internet. However, this approach has limitations and can be cumbersome for testing and development purposes.
The local SSL proxy provides a more streamlined solution by allowing the app to be accessed locally through a .test domain. This simplifies the setup process and ensures a secure and reliable connection for local testing.
Key Changes:
Added the local-ssl-proxy library to the project dependencies.
Added an npm script to generate the certificate and configure the proxy.
Updated the app's configuration to utilize the local SSL proxy for serving requests.
Documented the necessary steps for setting up and using the local SSL proxy in the README file.
Benefits:
Improved development workflow: With the local SSL proxy, developers can quickly and easily access the app using the .test domain, eliminating the need for external services like Ngrok.
Enhanced security: The local SSL proxy ensures secure connections between the app and the local machine, protecting sensitive data during testing and development.
Simplified setup: By utilizing the .test domain, the setup process becomes more straightforward and reduces the dependencies on third-party services.