Implement 'always play on repeat' setting in webapp

killergerbah · Jan 11, 2024 · 366e6e5 · 366e6e5
1 parent 6415a65
commit 366e6e5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/common/app/components/SubtitlePlayer.tsx b/common/app/components/SubtitlePlayer.tsx
@@ -592,13 +592,13 @@ export default function SubtitlePlayer({
             (event, subtitle) => {
                 event.preventDefault();
                 event.stopPropagation();
-                onSeek(subtitle.start, playingRef.current ?? false);
+                onSeek(subtitle.start, settings.alwaysPlayOnSubtitleRepeat || (playingRef.current ?? false));
             },
             () => disableKeyEvents,
             () => clock.time(length),
             () => subtitles
         );
-    }, [keyBinder, onSeek, subtitles, disableKeyEvents, clock, length]);
+    }, [keyBinder, onSeek, subtitles, disableKeyEvents, clock, length, settings]);
 
     useEffect(() => {
         return keyBinder.bindSeekBackwardOrForward(

diff --git a/common/app/components/VideoPlayer.tsx b/common/app/components/VideoPlayer.tsx
@@ -689,12 +689,16 @@ export default function VideoPlayer({
             (event, subtitle) => {
                 event.preventDefault();
                 playerChannel.currentTime(subtitle.start / 1000);
+
+                if (settings.alwaysPlayOnSubtitleRepeat) {
+                    playerChannel.play();
+                }
             },
             () => !videoRef.current,
             () => clock.time(length),
             () => subtitles
         );
-    }, [keyBinder, playerChannel, subtitles, length, clock]);
+    }, [keyBinder, playerChannel, subtitles, length, clock, settings]);
 
     useEffect(() => {
         return keyBinder.bindSeekBackwardOrForward(