Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified logic in slide response. #40

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

oniietzschan
Copy link
Contributor

I was going through the bump source code recently and saw an opportunity for a small readability improvement to the slide function. I think removing sx and sy makes it a tad easier to understand, hopefully you'll agree.

I also added --no-max-line-length so that the Travis build would pass. I think luacheck started getting upset about lines longer than 120 character since a commit was last made to this repo.

@coveralls
Copy link

coveralls commented Sep 10, 2017

Coverage Status

Coverage decreased (-0.009%) to 96.429% when pulling ca27d8c on oniietzschan:shru-cleanup into 72d6b13 on kikito:master.

@pablomayobre
Copy link

No idea why coveralls is reporting a decrease in coverage, but this should affect that much.

Most likely is to the file size reduction, 2 lines being removed could result in a % decrease. The logic is fine and the simplification really help with readability.

I would totally merge this

@kikito kikito merged commit 20ad16b into kikito:master Feb 9, 2018
@kikito
Copy link
Owner

kikito commented Feb 9, 2018

Yes, this makes total sense, thanks a lot for cleaning up that piece of code!

@oniietzschan oniietzschan deleted the shru-cleanup branch March 28, 2019 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants